From 431cba9a4bcef0e0ae047d45a7f3d98e601e30ed Mon Sep 17 00:00:00 2001 From: bd Date: Fri, 21 Mar 2025 16:06:07 -0400 Subject: Small cleanups to up a lot of inplementation details --- src/storage/cache.cc | 84 +++++++++++++++++++--------------------------------- 1 file changed, 31 insertions(+), 53 deletions(-) (limited to 'src/storage/cache.cc') diff --git a/src/storage/cache.cc b/src/storage/cache.cc index f15c919..a4ae4ca 100644 --- a/src/storage/cache.cc +++ b/src/storage/cache.cc @@ -27,50 +27,26 @@ Cache::~Cache() Response Cache::write_word(Accessor accessor, signed int data, int address) { - Response r = WAIT; - - /* Do this first--then process the first cycle immediately. */ - if (this->requester == IDLE) - this->requester = accessor; - - if (this->requester == accessor) { - handle_miss(address); - if (this->is_waiting) - r = BLOCKED; - else if (this->wait_time == 0) { - int tag, index, offset; - get_bit_fields(address, &tag, &index, &offset); - this->data->at(index).at(offset) = data; - this->meta[index].at(1) = 1; - r = OK; - } + Response r = this->is_access_cleared(accessor, address); + if (r == OK) { + int tag, index, offset; + get_bit_fields(address, &tag, &index, &offset); + this->data->at(index).at(offset) = data; + this->meta[index].at(1) = 1; } - return r; } Response Cache::write_line( Accessor accessor, std::array data_line, int address) { - Response r = WAIT; - - /* Do this first--then process the first cycle immediately. */ - if (this->requester == IDLE) - this->requester = accessor; - - if (this->requester == accessor) { - handle_miss(address); - if (this->is_waiting) - r = BLOCKED; - else if (this->wait_time == 0) { - int tag, index, offset; - get_bit_fields(address, &tag, &index, &offset); - this->data->at(index) = data_line; - this->meta[index].at(1) = 1; - r = OK; - } + Response r = this->is_access_cleared(accessor, address); + if (r == OK) { + int tag, index, offset; + get_bit_fields(address, &tag, &index, &offset); + this->data->at(index) = data_line; + this->meta[index].at(1) = 1; } - return r; } @@ -80,26 +56,31 @@ Response Cache::read_line( int address, std::array &data_line) { - Response r = WAIT; - if (this->requester == IDLE) - this->requester = accessor; - if (this->requester == accessor) { - handle_miss(address); - if (this->is_waiting) - r = BLOCKED; - else if (this->wait_time == 0) { - int tag, index, offset; - get_bit_fields(address, &tag, &index, &offset); - data_line = this->data->at(index); - r = OK; - } + Response r = this->is_access_cleared(accessor, address); + if (r == OK) { + int tag, index, offset; + get_bit_fields(address, &tag, &index, &offset); + data_line = this->data->at(index); } return r; } Response Cache::read_word(Accessor accessor, int address, signed int &data) { - Response r = WAIT; + Response r = this->is_access_cleared(accessor, address); + if (r == OK) { + int tag, index, offset; + get_bit_fields(address, &tag, &index, &offset); + data = this->data->at(index).at(offset); + } + return r; +} + +Response Cache::is_access_cleared(Accessor accessor, int address) +{ + Response r; + r = WAIT; + /* Do this first--then process the first cycle immediately. */ if (this->requester == IDLE) this->requester = accessor; if (this->requester == accessor) { @@ -107,9 +88,6 @@ Response Cache::read_word(Accessor accessor, int address, signed int &data) if (this->is_waiting) r = BLOCKED; else if (this->wait_time == 0) { - int tag, index, offset; - get_bit_fields(address, &tag, &index, &offset); - data = this->data->at(index).at(offset); r = OK; } } -- cgit v1.2.3 From a29cd5297d2d66f05ea91d05175fdc9fd4b2fef3 Mon Sep 17 00:00:00 2001 From: bd Date: Fri, 21 Mar 2025 16:42:16 -0400 Subject: add 'process' function to handle boilerplate on every request --- inc/cache.h | 12 ++++++++++++ inc/dram.h | 12 ++++++++++++ src/storage/cache.cc | 38 +++++++++++++++++++------------------- src/storage/dram.cc | 38 +++++++++++++++++++------------------- 4 files changed, 62 insertions(+), 38 deletions(-) (limited to 'src/storage/cache.cc') diff --git a/inc/cache.h b/inc/cache.h index a5fa16e..ef9c9e4 100644 --- a/inc/cache.h +++ b/inc/cache.h @@ -41,6 +41,18 @@ class Cache : public Storage std::array, L1_CACHE_LINES> get_meta() const; private: + /** + * Helper for all access methods. + * Calls `request_handler` when `accessor` is allowed to complete its + * request cycle. + * @param the source making the request + * @param the address to write to + * @param the function to call when an access should be completed + */ + Response process( + Accessor accessor, + int address, + std::function request_handler); /** * Returns OK if `accessor` is allowed to complete its request this cycle. * Handles cache misses, wait times, and setting the current accessor this diff --git a/inc/dram.h b/inc/dram.h index ff2c298..e6db633 100644 --- a/inc/dram.h +++ b/inc/dram.h @@ -31,6 +31,18 @@ class Dram : public Storage read_word(Accessor accessor, int address, signed int &data) override; private: + /** + * Helper for all access methods. + * Calls `request_handler` when `accessor` is allowed to complete its + * request cycle. + * @param the source making the request + * @param the address to write to + * @param the function to call when an access should be completed + */ + Response process( + Accessor accessor, + int address, + std::function request_handler); /** * Returns OK if `accessor` is allowed to complete its request this cycle. * Handles wait times, side door, and setting the current accessor this diff --git a/src/storage/cache.cc b/src/storage/cache.cc index a4ae4ca..8acdf08 100644 --- a/src/storage/cache.cc +++ b/src/storage/cache.cc @@ -27,27 +27,20 @@ Cache::~Cache() Response Cache::write_word(Accessor accessor, signed int data, int address) { - Response r = this->is_access_cleared(accessor, address); - if (r == OK) { - int tag, index, offset; - get_bit_fields(address, &tag, &index, &offset); + return process(accessor, address, [&](int index, int offset) { this->data->at(index).at(offset) = data; this->meta[index].at(1) = 1; - } - return r; + }); } Response Cache::write_line( Accessor accessor, std::array data_line, int address) { - Response r = this->is_access_cleared(accessor, address); - if (r == OK) { - int tag, index, offset; - get_bit_fields(address, &tag, &index, &offset); + return process(accessor, address, [&](int index, int offset) { + (void)offset; this->data->at(index) = data_line; this->meta[index].at(1) = 1; - } - return r; + }); } // TODO: tests for multi level cache @@ -56,22 +49,29 @@ Response Cache::read_line( int address, std::array &data_line) { - Response r = this->is_access_cleared(accessor, address); - if (r == OK) { - int tag, index, offset; - get_bit_fields(address, &tag, &index, &offset); + return process(accessor, address, [&](int index, int offset) { + (void)offset; data_line = this->data->at(index); - } - return r; + }); } Response Cache::read_word(Accessor accessor, int address, signed int &data) +{ + return process(accessor, address, [&](int index, int offset) { + data = this->data->at(index).at(offset); + }); +} + +Response Cache::process( + Accessor accessor, + int address, + std::function request_handler) { Response r = this->is_access_cleared(accessor, address); if (r == OK) { int tag, index, offset; get_bit_fields(address, &tag, &index, &offset); - data = this->data->at(index).at(offset); + request_handler(index, offset); } return r; } diff --git a/src/storage/dram.cc b/src/storage/dram.cc index 779e392..2c24b4b 100644 --- a/src/storage/dram.cc +++ b/src/storage/dram.cc @@ -24,24 +24,17 @@ Dram::~Dram() { delete this->data; } Response Dram::write_line( Accessor accessor, std::array data_line, int address) { - Response r = this->is_access_cleared(accessor); - if (r == OK) { - int line, word; - get_memory_index(address, line, word); + return process(accessor, address, [&](int line, int word) { + (void)word; this->data->at(line) = data_line; - } - return r; + }); } Response Dram::write_word(Accessor accessor, signed int data, int address) { - Response r = this->is_access_cleared(accessor); - if (r == OK) { - int line, word; - get_memory_index(address, line, word); + return process(accessor, address, [&](int line, int word) { this->data->at(line).at(word) = data; - } - return r; + }); } // TODO requires testing @@ -50,22 +43,29 @@ Response Dram::read_line( int address, std::array &data_line) { - Response r = this->is_access_cleared(accessor); - if (r == OK) { - int line, word; - get_memory_index(address, line, word); + return process(accessor, address, [&](int line, int word) { + (void)word; data_line = this->data->at(line); - } - return r; + }); } Response Dram::read_word(Accessor accessor, int address, signed int &data) +{ + return process(accessor, address, [&](int line, int word) { + data = this->data->at(line).at(word); + }); +} + +Response Dram::process( + Accessor accessor, + int address, + std::function request_handler) { Response r = this->is_access_cleared(accessor); if (r == OK) { int line, word; get_memory_index(address, line, word); - data = this->data->at(line).at(word); + request_handler(line, word); } return r; } -- cgit v1.2.3