From 6f4e9e0b914c3e68691a5d884cbad0b5813fcf18 Mon Sep 17 00:00:00 2001
From: bd <bdunahu@operationnull.com>
Date: Sat, 10 May 2025 22:28:01 -0400
Subject: Fix bug where too many vector elements were written back

---
 src/ex.cc |  1 -
 src/wb.cc | 37 +++++++++++++++++++++++++++----------
 2 files changed, 27 insertions(+), 11 deletions(-)

(limited to 'src')

diff --git a/src/ex.cc b/src/ex.cc
index 066f584..56a59d7 100644
--- a/src/ex.cc
+++ b/src/ex.cc
@@ -231,7 +231,6 @@ void EX::handle_vector_operations(
 		}
 		this->set_condition(EQ, eq);
 		break;
-
 	default:
 		throw std::invalid_argument(
 			"handle_vector_operations received an integer operation!");
diff --git a/src/wb.cc b/src/wb.cc
index e174157..bfdbc3a 100644
--- a/src/wb.cc
+++ b/src/wb.cc
@@ -16,9 +16,9 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 #include "wb.h"
+#include "instr.h"
 #include "instrDTO.h"
 #include "response.h"
-#include "instr.h"
 #include "stage.h"
 #include <algorithm>
 #include <array>
@@ -53,14 +53,20 @@ void WB::write_handler()
 	this->checked_out.pop_front();
 	reg = this->curr_instr->checked_out;
 
-	if(this->curr_instr->type != SI_INT) {
-		if(this->curr_instr->mnemonic != STOREV && this->curr_instr->mnemonic != LOADV) {
-			this->store_register<std::array<signed int, V_R_LIMIT>>(reg, this->curr_instr->operands.vector.slot_one);
-		} else {
-			this->store_register<std::array<signed int, V_R_LIMIT>>(reg, this->curr_instr->operands.i_vector.slot_three);
-		}
-	} else{
-		this->store_register<signed int>(reg, this->curr_instr->operands.integer.slot_one);
+	switch (this->curr_instr->type) {
+	case SI_INT:
+		this->store_register<signed int>(
+			reg, this->curr_instr->operands.integer.slot_one);
+		break;
+	case R_VECT:
+		this->store_register<std::array<signed int, V_R_LIMIT>>(
+			reg, this->copy_extra_vector_elements());
+		break;
+	case I_VECT:
+		this->store_register<std::array<signed int, V_R_LIMIT>>(
+			reg, this->curr_instr->operands.i_vector.slot_three);
+		// todo, use copy_extra_vector_elements
+		break;
 	}
 }
 
@@ -69,7 +75,6 @@ void WB::jump_handler()
 	if (this->curr_instr->operands.integer.slot_one > 0) {
 		if (this->curr_instr->mnemonic == JAL)
 			this->gprs[1] = this->curr_instr->slot_B + 1;
-		;
 		this->pc = this->curr_instr->operands.integer.slot_one;
 		this->checked_out = {};
 		this->next->squash();
@@ -86,3 +91,15 @@ bool WB::should_jump()
 	else
 		return false;
 }
+
+std::array<signed int, V_R_LIMIT> WB::copy_extra_vector_elements()
+{
+	int i;
+	std::array<signed int, V_R_LIMIT> v;
+
+	v = this->curr_instr->operands.vector.slot_one;
+	for (i = V_R_LIMIT - 1; i >= this->curr_instr->slot_B; --i) {
+		v[i] = this->curr_instr->operands.vector.slot_three[i];
+	}
+	return v;
+}
-- 
cgit v1.2.3