diff options
| author | Siddarth-Suresh <65844402+Siddarth-Suresh@users.noreply.github.com> | 2025-03-09 12:49:31 -0400 |
|---|---|---|
| committer | Siddarth-Suresh <65844402+Siddarth-Suresh@users.noreply.github.com> | 2025-03-09 12:49:31 -0400 |
| commit | 035eba9d7a3b1c68b57bf954d0e3983d6e5f11e5 (patch) | |
| tree | 9a7f7545d32fc488331143454603c07b9ccd732f | |
| parent | b87f192702f5a02be473c9b05b8b34f1dc7e4296 (diff) | |
Code review comments
| -rw-r--r-- | inc/dram.h | 5 | ||||
| -rw-r--r-- | src/storage/dram.cc | 5 | ||||
| -rw-r--r-- | tests/dram.cc | 1 |
3 files changed, 6 insertions, 5 deletions
@@ -19,10 +19,7 @@ class Dram : public Storage Response read(Accessor accessor, int address, std::array<signed int, LINE_SIZE>& data) override; private: - void do_read(std::array<signed int, LINE_SIZE>& data_line, int address){ - int line = address / LINE_SIZE; - data_line = this->data->at(line); - } + void do_read(std::array<signed int, LINE_SIZE>& data_line, int address); }; #endif /* DRAM_H_INCLUDED */ diff --git a/src/storage/dram.cc b/src/storage/dram.cc index 43c092d..0db4c35 100644 --- a/src/storage/dram.cc +++ b/src/storage/dram.cc @@ -38,6 +38,11 @@ Response Dram::write(Accessor accessor, signed int data, int address) return r; } +void Dram::do_read(std::array<signed int, LINE_SIZE>& data_line, int address){ + int line = address / LINE_SIZE; + data_line = this->data->at(line); +} + Response Dram::read(Accessor accessor, int address, std::array<signed int, LINE_SIZE>& data) { Response r = WAIT; if (this->requester == IDLE) diff --git a/tests/dram.cc b/tests/dram.cc index 484b459..95ef90a 100644 --- a/tests/dram.cc +++ b/tests/dram.cc @@ -2,7 +2,6 @@ #include "definitions.h" #include <array> #include <catch2/catch_test_macros.hpp> -#include <iostream> TEST_CASE("Construct singleton dram", "[dram]") { |